Repository navigation
feat(work): reuse prepared source input and control metadata pages (#1017) - #1200
Merged
Merged
Conversation
…nto agent/1017-refill-consumer
…nto agent/1017-refill-consumer
…' into agent/1017-refill-source
… agent/1017-refill-source
Collaborator
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature A — native board (#1214, #1017). T2. Ports #307 row night-watch + feeder + goal-loop → board: assignment/leases. Prerequisite for #1192; #1162/#1166/#1173 are merged. Complete diff: four files, 284 additions.
The refill source needs complete normalized PR facts and fresh branch/link/issue metadata before admission. A single metadata page rejected valid paginated repositories and could miss a later PR that already covers an approved issue. Extracts #1192's existing Prepared/Input code into one reused module over the existing Reader. Metadata pages retain the global PR count and exact membership/heads; duplicate rows, missing pages/cursors, stalled pagination, changed heads and truncated nested links refuse the snapshot. Facts and metadata share one byte bound. Explicit issue inputs require current state/revision/link checks; the forty-open-PR intake cap applies before partition. Revalidation refreshes the same facts before claims.
Removes: the consuming CLI's separate Input implementation in dependent #1192; both consumers use this single adapter. No new transport, credentials, worker registry, task builder or state store.
CI only: tests-first 5be12e8 failed lane 44168464619 at both new runtime controls on both architectures (x86: 2/1298, partial-connection refusal). Fixed d9f630b passed 44170035668; formatting/dependency head a07d947 passed 44178473776, both x86_64+aarch64. Controls cover a later-page linked PR, stale metadata/revision, explicit intake and the global cap. No local builds/tests.
Current exact head e9faf01 normally merges main after #1162 landed; behavior and assertions are unchanged. Lane 44184068201 passed on x86_64 and aarch64 (oxa-cli, oxa-parity, oxa-work) at this exact head. Required checks 44184124467 also passed, including formatting, clippy, the real oxa build, both mandatory-bwrap workspace partitions and the exact-once/no-runtime-skip inventory guard. Prior green results are historical evidence. Exact-head Codex code review is clear: #1200 (comment) (summary 6962249967 records completed, no findings). Normal approval and merge-queue validation remain required.
This adapter alone does not complete live #307 acceptance. Native CLI lifecycle qualification, immutable receipt retention before publication and fenced release at true native completion remain same-row prerequisites. Publication/activation remain off pending composition and owner qualification; no helper starts.